Coding 2022-11-26
Okay, I got some solid work in on MOTR today. I finished up the typing issues, fixed some minor formatting issues, and had no test issues, which is a good sign, because I shouldn't have been changing any behavior.
There were some issues with the merges.
- The first merge had the issue that it was not a merge, because I hadn't diverged from an ancestor, so instead I had to, from the changed topic, mark the current topic as the ancestor topic, and add an empty commit. I feel like there should be a better way to do that, in terms of ergonomics, and there probably is; I just didn't ask.
- The second merge was more of a straightforward "there are pervasive changes in the code that are right next to each other, and the diff algorithm decided to be cautious".
Anyway, now I'm feeling good to add tests around this code, now that the types for it make a bit more sense. To review what I need to start with:
- InstallerArgs instance
- EnvironmentArgs instance
There are some other things, but I don't want to think too hard right now. Once I've had some more sleep, I can review the relevant code, now that I've messed with it, and figure out the right way to access the relevant classes and functions.
For now, I need to get ready for bed.
Good night.